[libcxx-commits] [clang] [libcxx] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

Peter Waller via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 30 02:58:16 PDT 2024


peterwaller-arm wrote:

Thanks @wzssyqa again for implementing this and splitting bits out per Sander's suggestion. I propose we merge these changes tomorrow, on the understanding that each of the two patches (this and #90313) are passing tests. It looks to me like you're working towards that goal.

What I see in CI for this PR is `LLVM-Unit :: TargetParser/./TargetParserTests/TripleTest/Normalization` is currently failing.

Is it possible to have two patches such that they're both green? My expectation is that the majority of the triple changes in the source are unrelated to normalization and would work the same before and after the functional changes to triple normalization. (And that those tests which are impacted by changes to triple normalization should of course change in the same commit to keep things green).

https://github.com/llvm/llvm-project/pull/89638


More information about the libcxx-commits mailing list