[libcxx-commits] [libcxx] libcxx tests: some tests are missing include for `numeric_limits` (PR #90345)

Alex Guteniev via libcxx-commits libcxx-commits at lists.llvm.org
Sat Apr 27 09:43:50 PDT 2024


https://github.com/AlexGuteniev updated https://github.com/llvm/llvm-project/pull/90345

>From 272b2fa8b79bd0ba119677ad114823ff9cf9b76f Mon Sep 17 00:00:00 2001
From: Alex Guteniev <gutenev at gmail.com>
Date: Sat, 27 Apr 2024 17:15:20 +0300
Subject: [PATCH 1/3] Missing include for `numeric_limits`

---
 .../numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp     | 1 +
 .../format/format.arguments/format.arg/visit_format_arg.pass.cpp | 1 +
 .../utilities/format/format.arguments/format.args/get.pass.cpp   | 1 +
 3 files changed, 3 insertions(+)

diff --git a/libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp b/libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp
index 6103f3e87d4f15..0d28cff511dee4 100644
--- a/libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp
+++ b/libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp
@@ -14,6 +14,7 @@
 // _Tp midpoint(_Float __a, _Float __b) noexcept
 //
 
+#include <limits>
 #include <numeric>
 #include <cassert>
 
diff --git a/libcxx/test/std/utilities/format/format.arguments/format.arg/visit_format_arg.pass.cpp b/libcxx/test/std/utilities/format/format.arguments/format.arg/visit_format_arg.pass.cpp
index 3497d8935c8d62..5ab8c649cc58c7 100644
--- a/libcxx/test/std/utilities/format/format.arguments/format.arg/visit_format_arg.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.arguments/format.arg/visit_format_arg.pass.cpp
@@ -16,6 +16,7 @@
 #include <algorithm>
 #include <format>
 #include <cassert>
+#include <limits>
 #include <type_traits>
 
 #include "constexpr_char_traits.h"
diff --git a/libcxx/test/std/utilities/format/format.arguments/format.args/get.pass.cpp b/libcxx/test/std/utilities/format/format.arguments/format.args/get.pass.cpp
index a5d3703397f4e4..c590cebf48accd 100644
--- a/libcxx/test/std/utilities/format/format.arguments/format.args/get.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.arguments/format.args/get.pass.cpp
@@ -14,6 +14,7 @@
 
 #include <format>
 #include <cassert>
+#include <limits>
 #include <type_traits>
 
 #include "test_macros.h"

>From 5742d97d55d5e687a36d4bb2ccb92f28de1ab65e Mon Sep 17 00:00:00 2001
From: Alex Guteniev <gutenev at gmail.com>
Date: Sat, 27 Apr 2024 18:03:29 +0300
Subject: [PATCH 2/3] +one more

---
 libcxx/test/std/strings/string.conversions/stol.pass.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libcxx/test/std/strings/string.conversions/stol.pass.cpp b/libcxx/test/std/strings/string.conversions/stol.pass.cpp
index 1e47bd50495757..f5d3c5b2a425ab 100644
--- a/libcxx/test/std/strings/string.conversions/stol.pass.cpp
+++ b/libcxx/test/std/strings/string.conversions/stol.pass.cpp
@@ -13,6 +13,7 @@
 
 #include <string>
 #include <cassert>
+#incluce <limits>
 #include <stdexcept>
 
 #include "test_macros.h"

>From cc64bec39c0a283ba2e46c58bf3d2252a198ce5d Mon Sep 17 00:00:00 2001
From: Alex Guteniev <gutenev at gmail.com>
Date: Sat, 27 Apr 2024 19:43:41 +0300
Subject: [PATCH 3/3] Update stol.pass.cpp

---
 libcxx/test/std/strings/string.conversions/stol.pass.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcxx/test/std/strings/string.conversions/stol.pass.cpp b/libcxx/test/std/strings/string.conversions/stol.pass.cpp
index f5d3c5b2a425ab..083a6aaff28c97 100644
--- a/libcxx/test/std/strings/string.conversions/stol.pass.cpp
+++ b/libcxx/test/std/strings/string.conversions/stol.pass.cpp
@@ -13,7 +13,7 @@
 
 #include <string>
 #include <cassert>
-#incluce <limits>
+#include <limits>
 #include <stdexcept>
 
 #include "test_macros.h"



More information about the libcxx-commits mailing list