[libcxx-commits] [libcxx] libcxx tests: some tests are missing include for `numeric_limits` (PR #90345)

Alex Guteniev via libcxx-commits libcxx-commits at lists.llvm.org
Sat Apr 27 07:18:09 PDT 2024


https://github.com/AlexGuteniev created https://github.com/llvm/llvm-project/pull/90345

Noticed while attampting microsoft/STL#4634

>From 272b2fa8b79bd0ba119677ad114823ff9cf9b76f Mon Sep 17 00:00:00 2001
From: Alex Guteniev <gutenev at gmail.com>
Date: Sat, 27 Apr 2024 17:15:20 +0300
Subject: [PATCH] Missing include for `numeric_limits`

---
 .../numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp     | 1 +
 .../format/format.arguments/format.arg/visit_format_arg.pass.cpp | 1 +
 .../utilities/format/format.arguments/format.args/get.pass.cpp   | 1 +
 3 files changed, 3 insertions(+)

diff --git a/libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp b/libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp
index 6103f3e87d4f15..0d28cff511dee4 100644
--- a/libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp
+++ b/libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp
@@ -14,6 +14,7 @@
 // _Tp midpoint(_Float __a, _Float __b) noexcept
 //
 
+#include <limits>
 #include <numeric>
 #include <cassert>
 
diff --git a/libcxx/test/std/utilities/format/format.arguments/format.arg/visit_format_arg.pass.cpp b/libcxx/test/std/utilities/format/format.arguments/format.arg/visit_format_arg.pass.cpp
index 3497d8935c8d62..5ab8c649cc58c7 100644
--- a/libcxx/test/std/utilities/format/format.arguments/format.arg/visit_format_arg.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.arguments/format.arg/visit_format_arg.pass.cpp
@@ -16,6 +16,7 @@
 #include <algorithm>
 #include <format>
 #include <cassert>
+#include <limits>
 #include <type_traits>
 
 #include "constexpr_char_traits.h"
diff --git a/libcxx/test/std/utilities/format/format.arguments/format.args/get.pass.cpp b/libcxx/test/std/utilities/format/format.arguments/format.args/get.pass.cpp
index a5d3703397f4e4..c590cebf48accd 100644
--- a/libcxx/test/std/utilities/format/format.arguments/format.args/get.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.arguments/format.args/get.pass.cpp
@@ -14,6 +14,7 @@
 
 #include <format>
 #include <cassert>
+#include <limits>
 #include <type_traits>
 
 #include "test_macros.h"



More information about the libcxx-commits mailing list