[libcxx-commits] [libcxx] [libc++][TZDB] Renames incomplete. (PR #89250)

Mark de Wever via libcxx-commits libcxx-commits at lists.llvm.org
Sat Apr 20 03:09:12 PDT 2024


mordante wrote:

> #89178 is related I think. If we want to go ahead with that, maybe we want to rename this to `_LIBCPP_HAS_EXPERIMENTAL_TZDB` or `_LIBCPP_HAS_EXPERIMENTAL_FEATURE_TZDB`. FWIW just `_EXPERIMENTAL_` makes it sound to me like it's in `std::experimental`.

Since at the moment #89178 does not change any of the experimental macros I'll land this now. We can change it afterwards; preferably when most of the new TZDB parts have landed. I've done one rename round after the Discord discussion and I'd prefer not to do a second one. (After everything has landed I still need to do quite a bit of work to get a better performance.)

https://github.com/llvm/llvm-project/pull/89250


More information about the libcxx-commits mailing list