[libcxx-commits] [libcxx] [libc++][NFC] Add additional tests for begin/end of std::ranges::take_view (PR #79085)

Konstantin Varlamov via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 17 21:29:45 PDT 2024


================
@@ -27,55 +28,104 @@ struct NonCommonSimpleView : std::ranges::view_base {
 static_assert(std::ranges::sized_range<NonCommonSimpleView>);
 static_assert(!std::ranges::sized_range<const NonCommonSimpleView>);
 
+using CommonInputIterPtrConstInt        = common_input_iterator<const int*>;
+using CountedCommonInputIterPtrConstInt = std::counted_iterator<CommonInputIterPtrConstInt>;
----------------
var-const wrote:

FWIW, I'd use a shorter name (which IMO is fine since it's only used within a single file). It's a super minor comment that's not worth another around of review, so no action necessary. :)

https://github.com/llvm/llvm-project/pull/79085


More information about the libcxx-commits mailing list