[libcxx-commits] [libcxx] Test re-adding warnings to test suite to see why they really fail. (PR #88789)

[via libcxx-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r 071ac0ae3029594167d2bb4d28859bdc36367034...ba163240a9a2f20fee96e7e79e4fb88698925113 libcxx/utils/libcxx/test/features.py libcxx/utils/libcxx/test/params.py
``````````

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- params.py	2024-04-15 20:27:53.000000 +0000
+++ params.py	2024-04-15 20:31:38.941364 +0000
@@ -34,11 +34,10 @@
     "-Wno-literal-suffix",  # GCC
     "-Wno-user-defined-literals",  # Clang
     # GCC warns about this when TEST_IS_CONSTANT_EVALUATED is used on a non-constexpr
     # function. (This mostly happens in C++11 mode.)
     # TODO(mordante) investigate a solution for this issue.
-
     # These warnings should be enabled in order to support the MSVC
     # team using the test suite; They enable the warnings below and
     # expect the test suite to be clean.
     "-Wsign-compare",
     "-Wunused-variable",
@@ -49,20 +48,14 @@
     # Disable warnings for extensions used in C++03
     "-Wno-local-type-template-args",
     "-Wno-c++11-extensions",
 
     # TODO(philnik) This fails with the PSTL.
-
     # Don't fail compilation in case the compiler fails to perform the requested
     # loop vectorization.
-
-
     # TODO: Find out why GCC warns in lots of places (is this a problem with always_inline?)
-
-
     # This doesn't make sense in real code, but we have to test it because the standard requires us to not break
-
 ]
 
 _allStandards = ["c++03", "c++11", "c++14", "c++17", "c++20", "c++23", "c++26"]
 
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/88789