[libcxx-commits] [libcxx] linear_congruential_engine: add using more precision to prevent overflow (PR #81583)

Mark de Wever via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 15 09:25:46 PDT 2024


https://github.com/mordante approved this pull request.

> I addressed some of the review comments, and responded to others with followup questions / suggestions.
> 
> > Can you update the commit message; it mentions the patch is WIP.
> 
> I'm not seeing that. The PR had "[WIP]" at one point, but I don't see that in the commit message itself. Could you clarify what exactly you want me to change?

At the end of the commit message
"
I currently consider this PR to be a WIP because a) I haven't gotten the test cases written properly to avoid failing when __int128 isn't available, and b) I'm not 100% sure about how I've structured / formatted the changes, and may still want to tweak it before merging. I'm making the PR now so I can start getting feedback if anybody has any.
"

Other than the last comments the patch LGTM! Thanks for your work and patience.

https://github.com/llvm/llvm-project/pull/81583


More information about the libcxx-commits mailing list