[libcxx-commits] [libcxx] 1a895bd - [libc++] Marks a variable const. (#88562)

via libcxx-commits libcxx-commits at lists.llvm.org
Sat Apr 13 04:46:03 PDT 2024


Author: Mark de Wever
Date: 2024-04-13T13:45:59+02:00
New Revision: 1a895bd95ea741dd4756121244f7c2b59e693f1c

URL: https://github.com/llvm/llvm-project/commit/1a895bd95ea741dd4756121244f7c2b59e693f1c
DIFF: https://github.com/llvm/llvm-project/commit/1a895bd95ea741dd4756121244f7c2b59e693f1c.diff

LOG: [libc++] Marks a variable const. (#88562)

This removes a TODO from the code base.

Added: 
    

Modified: 
    libcxx/include/__algorithm/sort.h

Removed: 
    


################################################################################
diff  --git a/libcxx/include/__algorithm/sort.h b/libcxx/include/__algorithm/sort.h
index 8a5e0211cdf4c1..07b5814639e9e4 100644
--- a/libcxx/include/__algorithm/sort.h
+++ b/libcxx/include/__algorithm/sort.h
@@ -696,9 +696,8 @@ __partition_with_equals_on_left(_RandomAccessIterator __first, _RandomAccessIter
   using _Ops = _IterOps<_AlgPolicy>;
   typedef typename iterator_traits<_RandomAccessIterator>::
diff erence_type 
diff erence_type;
   typedef typename std::iterator_traits<_RandomAccessIterator>::value_type value_type;
-  // TODO(LLVM18): Make __begin const, see https://reviews.llvm.org/D147089#4349748
-  _RandomAccessIterator __begin     = __first; // used for bounds checking, those are not moved around
-  const _RandomAccessIterator __end = __last;
+  const _RandomAccessIterator __begin = __first; // used for bounds checking, those are not moved around
+  const _RandomAccessIterator __end   = __last;
   (void)__end; //
   value_type __pivot(_Ops::__iter_move(__first));
   if (__comp(__pivot, *(__last - 
diff erence_type(1)))) {


        


More information about the libcxx-commits mailing list