[libcxx-commits] [libcxx] [libc++][strings] P2591R5: Concatenation of strings and string views (PR #88389)

[Mark de Wever via libcxx-commits]

https://github.com/mordante commented:

Thanks for working on this. In general it looks correct, but I wonder whether you considered the performance of the wording in the paper.

The paper explicitly states it does not consider this at all for the wording, see https://isocpp.org/files/papers/P2591R5.html#minimizingallocations. There is a link to https://github.com/llvm/llvm-project/blob/llvmorg-14.0.0/libcxx/include/string#L4218.

The paper also mentions an implementation by @hawkinsw (https://github.com/llvm/llvm-project/compare/main...hawkinsw:llvm-project:P2591_string_view_concatenation) which at first glance did performance optimizations.

@hawkinsw did you benchmark your implementation?

(Note I read about the performance part in the paper after I already left some performance comments.)



https://github.com/llvm/llvm-project/pull/88389