[libcxx-commits] [libcxx] [libc++] Marks a variable const. (PR #88562)

Mark de Wever via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 12 11:58:17 PDT 2024


https://github.com/mordante created https://github.com/llvm/llvm-project/pull/88562

This removes a TODO from the code base.

>From 12ece886b6d59e3b7c6ebe0c2b1727e3e2f6fe60 Mon Sep 17 00:00:00 2001
From: Mark de Wever <koraq at xs4all.nl>
Date: Fri, 12 Apr 2024 20:57:16 +0200
Subject: [PATCH] [libc++] Marks a variable const.

This removes a TODO from the code base.
---
 libcxx/include/__algorithm/sort.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/libcxx/include/__algorithm/sort.h b/libcxx/include/__algorithm/sort.h
index 8a5e0211cdf4c1..07b5814639e9e4 100644
--- a/libcxx/include/__algorithm/sort.h
+++ b/libcxx/include/__algorithm/sort.h
@@ -696,9 +696,8 @@ __partition_with_equals_on_left(_RandomAccessIterator __first, _RandomAccessIter
   using _Ops = _IterOps<_AlgPolicy>;
   typedef typename iterator_traits<_RandomAccessIterator>::difference_type difference_type;
   typedef typename std::iterator_traits<_RandomAccessIterator>::value_type value_type;
-  // TODO(LLVM18): Make __begin const, see https://reviews.llvm.org/D147089#4349748
-  _RandomAccessIterator __begin     = __first; // used for bounds checking, those are not moved around
-  const _RandomAccessIterator __end = __last;
+  const _RandomAccessIterator __begin = __first; // used for bounds checking, those are not moved around
+  const _RandomAccessIterator __end   = __last;
   (void)__end; //
   value_type __pivot(_Ops::__iter_move(__first));
   if (__comp(__pivot, *(__last - difference_type(1)))) {



More information about the libcxx-commits mailing list