[libcxx-commits] [libcxx] [libc++] Removes a Clang 16 Windows workaround. (PR #88560)

via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 12 11:56:47 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Mark de Wever (mordante)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/88560.diff


1 Files Affected:

- (modified) libcxx/include/sstream (-8) 


``````````diff
diff --git a/libcxx/include/sstream b/libcxx/include/sstream
index 5873deb8318ecf..d339cf3f49e206 100644
--- a/libcxx/include/sstream
+++ b/libcxx/include/sstream
@@ -330,14 +330,6 @@ typedef basic_stringstream<wchar_t> wstringstream;
 _LIBCPP_PUSH_MACROS
 #include <__undef_macros>
 
-// TODO(LLVM-19): Remove this once we drop support for Clang 16,
-// which had this bug: https://github.com/llvm/llvm-project/issues/40363
-#ifdef _WIN32
-#  define _LIBCPP_HIDE_FROM_ABI_SSTREAM _LIBCPP_ALWAYS_INLINE
-#else
-#  define _LIBCPP_HIDE_FROM_ABI_SSTREAM _LIBCPP_HIDE_FROM_ABI
-#endif
-
 _LIBCPP_BEGIN_NAMESPACE_STD
 
 // Class template basic_stringbuf [stringbuf]

``````````

</details>


https://github.com/llvm/llvm-project/pull/88560


More information about the libcxx-commits mailing list