[libcxx-commits] [libcxx] [libc++] Implement LWG3430 disallow implicit conversion of the source arguments to `std::filesystem::path` when constructing `std::basic_*fstream` (PR #85079)

Nico Weber via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 11 11:21:59 PDT 2024


================
@@ -158,8 +158,8 @@ public:
     basic_fstream();
     explicit basic_fstream(const char* s, ios_base::openmode mode = ios_base::in|ios_base::out);
     explicit basic_fstream(const string& s, ios_base::openmode mode = ios_base::in|ios_base::out);
-    explicit basic_fstream(const filesystem::path& p,
-                           ios_base::openmode mode = ios_base::in|ios_base::out); C++17
+    template<class T>
+    explicit basic_fstream(const T& s, ios_base::openmode mode = ios_base::in | ios_base::out); // Since C++17
----------------
nico wrote:

Oh, I suppose I need to call `c_str()` on my wstring to get the wchar_t ctor. Let me try that; sorry for the noise.

(The point stands that this breaks existing code, though.)

https://github.com/llvm/llvm-project/pull/85079


More information about the libcxx-commits mailing list