[libcxx-commits] [libcxx] [libc++] Remove <queue> and <stack> includes from <format> (PR #85520)
Nico Weber via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Apr 10 10:07:23 PDT 2024
nico wrote:
> @nico In chromium you actually make the conscious decision to opt-in to removing transitive includes with `_LIBCPP_REMOVE_TRANSITIVE_INCLUDES`. By default these includes aren't removed currently.
Ah, cool.
I'll say that we added `_LIBCPP_REMOVE_TRANSITIVE_INCLUDES` 1.5 years ago after completing some cleanup back then. Projects committed to keeping libc++ up-to-date with includes kind of had to define it back then to prevent regressions. It wasn't clear to me that this is covering new include cleanups in perpetuity. For bigger include cleanups, it would be useful to have one of these defines per cleanup :P (…but there haven't been any large cleanups needed since we added `_LIBCPP_REMOVE_TRANSITIVE_INCLUDES` 1.5 years ago, so it's not an urgent problem or anything).
https://github.com/llvm/llvm-project/pull/85520
More information about the libcxx-commits
mailing list