[libcxx-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Apr 9 09:20:48 PDT 2024
https://github.com/ldionne approved this pull request.
I reviewed this in some amount of detail, but obviously the code here is really complex so without actually reimplementing it myself, I can't understand everything. However, this looks right to me and I am relying on your test coverage a lot. I think it would be very valuable to add fuzzing tests here, I am certain it would shake out a lot of issues.
This LGTM once all pending comments have been applied. Thanks a lot for the patch!
https://github.com/llvm/llvm-project/pull/85619
More information about the libcxx-commits
mailing list