[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

[Alexander Richardson via Phabricator via libcxx-commits]

arichardson added a comment.

Would very much like to see this land soon. Two small comments



================
Comment at: libcxx/test/configs/armv7m-libc++.cfg.in:17
+    # which for picolibc is defined in picolibc.h.
+    ' -include picolibc.h'
+))
----------------
Doesn't this mean the library can't be used without adding this include to any build system that is trying to use libc++ with picolibc? I think it would be a lot cleaner if we could just add the required includes to the libc++ source code?

As far as I recall from the last time I tried to use libc++ with picolibc this was not needed but I may have been building a slightly different configuration


================
Comment at: libcxx/test/configs/armv7m-libc++.cfg.in:38
+# using this feature.
+config.available_features.add('LIBCXX-PICOLIBC-FIXME')
+
----------------
Could this be autodetected instead by checking for the presence of the picolibc header? Then it would also work out of the box with the default config file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246