[libcxx-commits] [PATCH] D155312: [libc++] Use _Complex for multiplication and division of complex floating point types

Thu Sep 28 12:27:05 PDT 2023

mstorsjo added subscribers: thieta, hans, rnk.
mstorsjo added a comment.

In D155312#4651731 <https://reviews.llvm.org/D155312#4651731>, @ldionne wrote:

> @mstorsjo Do you know what's the state of things for compiler-rt on Windows?

In MinGW configs, compiler-rt is alive and well and everything works - and those configs work fine in that CI run.

> To summarize the issue, it seems like we are missing `__muldc3` and `__mulsc3` on Windows, which should be provided in compiler-rt (from https://buildkite.com/llvm-project/libcxx-ci/builds/29818#018aa944-7c19-4abf-8476-4b506918c33a).

Indeed; in clang-cl configs, compiler-rt builtins aren't linked. This is the same issue as the helpers for `__int128_t` that also are missing that we've run into in a few places. There were some efforts to work on this (with some discussion threads on Discourse in the last few months) with @thieta, @rnk, @hans and others.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155312/new/

https://reviews.llvm.org/D155312