[libcxx-commits] [libcxx] [libc++] Update a comment about -nostdlib++ (PR #67429)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Sep 27 06:48:19 PDT 2023


ldionne wrote:

> libc++ already requires GCC13, so this can be simplified now.

I think the real reason why we're still checking for whether `-nostdlib++` is supported is to handle Clang-cl, which doesn't support it IIUC. I think we could probably simplify that to be something like

```
if (MSVC)
  target_add_link_flags(${target} PRIVATE "/nodefaultlibs")
else()
  target_add_link_flags(${target} PRIVATE "-nostdlib++")
endif()
```

but then the rest of the function where we link against various system libraries will have to change too (we could drop a bunch of complexity on non-MSVC envs). @nico Do you want to go for that or do you want us to pick that up?

https://github.com/llvm/llvm-project/pull/67429


More information about the libcxx-commits mailing list