[libcxx-commits] [libcxx] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

[Louis Dionne via libcxx-commits]

================

----------------
ldionne wrote:

As I discussed in https://reviews.llvm.org/D150264#inline-1504645, I am a bit uncomfortable with the fact that this test checks both for OOB accesses and for the `_LIBCPP_DEBUG_STRICT_WEAK_ORDERING_CHECK` diagnostics. We should really have a test that checks for these OOB accesses and that is completely separate from the strict-weak-ordering check, which is a debug-mode only check.

Not for this patch, but a follow-up to split this up into two tests would be really great.

https://github.com/llvm/llvm-project/pull/67023