[libcxx-commits] [PATCH] D156019: [libc++] Adds __throw_system_error overload.

Daniel Thornburgh via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 25 16:13:22 PDT 2023


mysterymath added a comment.

It looks like this change is a likely root cause for a size regression on Fuchsia. In particular, Fuchsia maintains a hermetic `-fno-exceptions` multilib of `libc++.a` that is statically linked into other binaries/libraries. Previously, the no-exceptions version of this code didn't depend on the error code or category libraries, but this change seems to bring them into the link unnecessarily. Would it be possible to revert this or to fix it forward to keep the no-exception case separate from these routines?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156019/new/

https://reviews.llvm.org/D156019



More information about the libcxx-commits mailing list