[libcxx-commits] [PATCH] D80588: [libc++] Optimize vector push_back to avoid continuous load and store of end pointer

Mon Sep 25 15:07:12 PDT 2023

ldionne accepted this revision as: libc++.
ldionne added a comment.

In D80588#4648327 <https://reviews.llvm.org/D80588#4648327>, @EricWF wrote:

> A little more digging into this assembly can be found here: https://godbolt.org/z/TrWY7YMWW (or with LLVM IR: https://godbolt.org/z/69xzf7r74)
>
> I think this change is good and safe. Still pondering the "how to test this" question.

The correctness tests are already handled by our test suite. I agree we don't have a good way of testing performance changes right now, and that's a problem. I think I'd rather not block this patch on that issue since a lot of patches are in the same boat and we both agree this is a good change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80588/new/

https://reviews.llvm.org/D80588