[libcxx-commits] [PATCH] D156626: [libc++] Make the constraints as intended.

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added a comment.

The changes in the header seem correct to me, but we can't move forward till the commit message has been fixed.



================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.cust/iterator.cust.move/iter_move_rvalue.compile.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
I'd prefer that this be a runtime test, since it's something that needs to work in both cases. As such, we'll need to rework this test so it handles runtime too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156626/new/

https://reviews.llvm.org/D156626