[libcxx-commits] [PATCH] D158918: [libc++abi][WebAssembly] Support Wasm EH
Petr Hosek via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Sep 21 10:48:38 PDT 2023
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: libcxxabi/src/cxa_personality.cpp:35
+#if defined(__USING_SJLJ_EXCEPTIONS__) || defined (__USING_WASM_EXCEPTIONS__)
+#define __USING_SJLJ_OR_WASM_EXCEPTIONS__
+#endif
----------------
I'd slightly prefer inlining this as `#if defined(__USING_SJLJ_EXCEPTIONS__) || defined (__USING_WASM_EXCEPTIONS__)` to avoid introducing another define since it's only used in a handful of places.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158918/new/
https://reviews.llvm.org/D158918
More information about the libcxx-commits
mailing list