[libcxx-commits] [PATCH] D132509: [libc++] Use _Lazy in tuple constructors

[Hui via Phabricator via libcxx-commits]

huixie90 accepted this revision as: huixie90.
huixie90 added a comment.

Thanks LGTM!



================
Comment at: libcxx/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/recursion_depth.pass.cpp:20-21
+
+template <std::size_t I>
+struct constructible_from_integral_constant : std::integral_constant<std::size_t, I> { };
+
----------------
unused and remove?


================
Comment at: libcxx/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/recursion_depth.pass.cpp:31
+
+  TargetTuple t1 = tuple;                                  // converting copy constructor
+  TargetTuple t2 = std::move(tuple);                       // converting move constructor
----------------
nit: for completeness , perhaps we can have another test to test the `const tuple&` overload? (although source code is not in this patch) 

```
TargetTuple t5 = std::as_const(tuple);  
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132509/new/

https://reviews.llvm.org/D132509