[libcxx-commits] [PATCH] D150747: [libc++][ranges] Add benchmarks for the `from_range` constructors of `vector` and `deque`.

[Siva Chandra via Phabricator via libcxx-commits]

sivachandra added inline comments.


================
Comment at: libcxx/benchmarks/CMakeLists.txt:87
+else()
+  target_compile_features( cxx-benchmarks-flags INTERFACE cxx_std_23)
+endif()
----------------
var-const wrote:
> sivachandra wrote:
> > This line seems to have taken down the runtimes sphinx docs builder: https://lab.llvm.org/buildbot/#/builders/242/builds/950
> > 
> > The builder seems to be using an old version of gcc which doesn't know about `cxx_std_23`. Could we perhaps skip `benchmarks` if we are using an old compiler?
> Hopefully https://github.com/llvm/llvm-zorg/pull/47 will fix that.
Thanks. It needs a buildbot restart to take effect, which hopefully will happen soon enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150747/new/

https://reviews.llvm.org/D150747