[libcxx-commits] [PATCH] D159171: [libc++][hardening] Remove hardening from release notes, undeprecate safe mode

Tue Sep 19 01:11:19 PDT 2023

thesamesam added a comment.

a5e5eb17fd9743ea39de35f2779c6dc10729cf9f <https://reviews.llvm.org/rGa5e5eb17fd9743ea39de35f2779c6dc10729cf9f> doesn't really explain the rationale here. Anyway, we picked up that _ENABLE_ASSERTIONS was deprecated thanks to this warning during the RCs (https://bugs.gentoo.org/912223). This change reverting to the old behaviour wasn't in any of the RCs and have now become "experimental" again.

I'll adjust our config files again but I feel like this would've been better to not do at all if it wasn't going to be tested in a final RC given it actively requires changes for downstreams.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159171/new/

https://reviews.llvm.org/D159171