[libcxx-commits] [libcxx] [libc++] Make sure LWG2070 is implemented as a DR (PR #65998)

[David Blaikie via libcxx-commits]

dwblaikie wrote:

> > > > Looks like this commit was made without approval? Were all the concerns addressed/did someone approve this
> > > > Nah, just process concerns. It'd be good to get someone to punch the approve button if that's the consensus from Discord, etc - just for appearances/norms - I worry about newer contributors getting the wrong impression about making value calls about whether the review is "enough" before committing & hope we all wait for formal approval once something's sent for formal review.
> 
> Yeah, I understand. I would argue that with Github PRs, most contributors shouldn't even need commit access, and then it would be the various maintainers' job to merge PRs. That would make this unambiguous. However I don't expect that this opinion is going to be very popular.

Yeah, I think we'll probably get there eventually - the days of review-after-commit being scalable/feasible/actually providing any checks and balances are probably well behind us & our process has some catching up to do with the modern scale of the project.

https://github.com/llvm/llvm-project/pull/65998