[libcxx-commits] [libcxx] [libc++] Make sure LWG2070 is implemented as a DR (PR #65998)

[David Blaikie via libcxx-commits]

dwblaikie wrote:

> > Looks like this commit was made without approval? Were all the concerns addressed/did someone approve this through another medium?
> 
> We discussed it on Discord and like I recorded above, the original concerns were addressed. 

Ah, yeah - sorry, I saw your comments after I posted my reply (I'd just skimmed looking for approval, or informal approval in the form of a comment where someone might've forgot to pick the "approve" button) - didn't mean to be obtuse.

> I committed it with the usual understanding that if there is something that needs to be addressed, it can be addressed post-commit like is quite usual in LLVM. Do you have any concrete concerns?

Nah, just process concerns. It'd be good to get someone to punch the approve button if that's the consensus from Discord, etc - just for appearances/norms - I worry about newer contributors getting the wrong impression about making value calls about whether the review is "enough" before committing & hope we all wait for formal approval once something's sent for formal review.



https://github.com/llvm/llvm-project/pull/65998