[libcxx-commits] [libcxx] [libcxx] Replace a few _LIBCPP_INLINE_VISIBILITY with _LIBCPP_HIDE_FR… (PR #66661)

[Louis Dionne via libcxx-commits]

ldionne wrote:

I must admit I am not convinced by this change. We now have roughly 50/50 uses of `_LIBCPP_HIDE_FROM_ABI` and `_LIBCPP_INLINE_VISIBILITY`, so while things have been changing slowly, they definitely have been changing. If we do this kind of large batch renaming, I might argue for also `clang-format`ing the files that are being touched.

The cost of making this change is not the review of the change itself, it's mainly the cost of rebasing all the other in-flight patches that might conflict with it. One thing to consider is that we're draining the Phabricator review queue right now and I've already dealt with a lot of interesting conflicts that were not easy to rebase. If we move forward with this patch, I would like to request that we at least not move forward with it before we're done with the Phabricator queue cleanup.

https://github.com/llvm/llvm-project/pull/66661