[libcxx-commits] [libcxx] [libc++][lit] Atomically update the persistent cache (PR #66538)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 18 09:07:51 PDT 2023


================
@@ -69,8 +69,14 @@ def f(config, *args, **kwargs):
             if cacheKey not in cache:
                 cache[cacheKey] = function(config, *args, **kwargs)
                 # Update the persistent cache so it knows about the new key
-                with open(persistentCache, "wb") as cacheFile:
+                # We write to a PID-suffixed file and rename the result to
----------------
ldionne wrote:

Oh, right -- then we'd basically lose this optimization entirely. OK, I guess I am fine with the current approach then.

https://github.com/llvm/llvm-project/pull/66538


More information about the libcxx-commits mailing list