[libcxx-commits] [libcxx] [libcxx] Replace a few _LIBCPP_INLINE_VISIBILITY with _LIBCPP_HIDE_FR… (PR #66661)

Nico Weber via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 18 09:06:02 PDT 2023


nico wrote:

The cost is that someone has to scroll through this for 10 minutes. That's faster than most actual reviews.

The comment was added in cb3eb30636c8d, so if things change at the rate they've been changing in, they won't.

I'm also happy to split this in 10 (or whatever) PRs if you think that helps. But just doing it seems reasonably quick, so I'm not sure spending a lot of time discussing the process is worth the time the discussion takes.

https://github.com/llvm/llvm-project/pull/66661


More information about the libcxx-commits mailing list