[libcxx-commits] [PATCH] D157058: [libc++] Remove generic char_traits implementation

Mon Sep 18 08:58:00 PDT 2023

thakis added inline comments.

================
Comment at: libcxx/include/__string/char_traits.h:107
-    _LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR_SINCE_CXX17
-    size_t length(const char_type* __s) {
-        size_t __len = 0;
----------------
philnik wrote:
> thakis wrote:
> > In https://github.com/mitchdowd/jnipp/pull/40 someone brought up ABI implications of this change. Most, but not all, methods of this class are marked `_LIBCPP_HIDE_FROM_ABI`. For example, this one isn't. Since these methods are all inline methods, it's probably fine, but does anyone know why some methods here have `_LIBCPP_HIDE_FROM_ABI` but others don't?
> `_LIBCPP_INLINE_VISIBILITY` is a deprecated alias for `_LIBCPP_HIDE_FROM_ABI`, so it is in fact marked `_LIBCPP_HIDE_FROM_ABI`. If any are missing that's an oversight that should be fixed.
Thanks for explaining! I made https://github.com/llvm/llvm-project/pull/66661 so you don't have to explain this again in the future.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157058/new/

https://reviews.llvm.org/D157058