[libcxx-commits] [libcxx] [libc++][lit] Atomically update the persistent cache (PR #66538)

[Louis Dionne via libcxx-commits]

================
@@ -69,8 +69,14 @@ def f(config, *args, **kwargs):
             if cacheKey not in cache:
                 cache[cacheKey] = function(config, *args, **kwargs)
                 # Update the persistent cache so it knows about the new key
-                with open(persistentCache, "wb") as cacheFile:
+                # We write to a PID-suffixed file and rename the result to
----------------
ldionne wrote:

Per the comments in the other thread, I would expect that we can simply make `persistentCache = os.path.join(cacheRoot, function.__name__, str(os.getpid()))` and not `replace` anything?

https://github.com/llvm/llvm-project/pull/66538