[libcxx-commits] [libcxxabi] [libc++abi][test][VE] Add '-ldl' to support VE (PR #66605)
via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Sep 17 16:37:37 PDT 2023
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxxabi
<details>
<summary>Changes</summary>
Tests are linked under -nostdlib++ option, so it is required to add system's libraries correctly. So, I add libdl.so which is required for VE.
---
Full diff: https://github.com/llvm/llvm-project/pull/66605.diff
1 Files Affected:
- (modified) libcxxabi/test/configs/llvm-libc++abi-shared.cfg.in (+10-3)
``````````diff
diff --git a/libcxxabi/test/configs/llvm-libc++abi-shared.cfg.in b/libcxxabi/test/configs/llvm-libc++abi-shared.cfg.in
index 6b69205da77c992..bb9a6514648e967 100644
--- a/libcxxabi/test/configs/llvm-libc++abi-shared.cfg.in
+++ b/libcxxabi/test/configs/llvm-libc++abi-shared.cfg.in
@@ -9,13 +9,20 @@ config.substitutions.append(('%{flags}',
config.substitutions.append(('%{compile_flags}',
'-nostdinc++ -I %{include} -I %{cxx-include} -I %{cxx-target-include} %{maybe-include-libunwind} -I %{libcxx}/test/support -I %{libcxx}/src -D_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS'
))
-config.substitutions.append(('%{link_flags}',
- '-nostdlib++ -L %{lib} -Wl,-rpath,%{lib} -lc++ -lc++abi -pthread'
-))
config.substitutions.append(('%{exec}',
'%{executor} --execdir %T -- '
))
+if config.root.target_triple.startswith('ve-'):
+ # VE requires libdl library.
+ config.substitutions.append(('%{link_flags}',
+ '-nostdlib++ -L %{lib} -Wl,-rpath,%{lib} -lc++ -lc++abi -pthread -ldl'
+ ))
+else:
+ config.substitutions.append(('%{link_flags}',
+ '-nostdlib++ -L %{lib} -Wl,-rpath,%{lib} -lc++ -lc++abi -pthread'
+ ))
+
import os, site
site.addsitedir(os.path.join('@LIBCXXABI_LIBCXX_PATH@', 'utils'))
import libcxx.test.params, libcxx.test.config
``````````
</details>
https://github.com/llvm/llvm-project/pull/66605
More information about the libcxx-commits
mailing list