[libcxx-commits] [PATCH] D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`

Hui via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Sep 16 02:41:52 PDT 2023


huixie90 added inline comments.


================
Comment at: libcxx/include/condition_variable:318
+            return true;
+        if (wait_until(__lock, __abs_time) == cv_status::timeout)
+            return __pred();
----------------
Mordante wrote:
> 
this is a member function call . not `std::wait_until`


================
Comment at: libcxx/include/condition_variable:327
+    _Lock& __lock, stop_token __stoken, const chrono::duration<_Rep, _Period>& __rel_time, _Predicate __pred) {
+    return wait_until(__lock, std::move(__stoken), chrono::steady_clock::now() + __rel_time, std::move(__pred));
+}
----------------
Mordante wrote:
> 
this is a member function call, not `std::wait_until`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153441/new/

https://reviews.llvm.org/D153441



More information about the libcxx-commits mailing list