[libcxx-commits] [libcxx] [libc++][hardening] Enable comparator checks for safe mode too (PR #66458)
Jordan Rupprecht via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Sep 15 14:24:37 PDT 2023
rupprecht wrote:
> > But for certain test modes, we're using this as a set of "extra asserts as long as they don't make the test timeout" type of build mode.
>
> What you're describing sounds like the debug mode rather than the safe mode. Is there any reason why you'd like to have these checks added to the safe mode rather than enable the debug mode?
Debug mode changes algorithmic complexity of certain algorithms, and causes some tests to timeout as a result. Safe mode still has all the interesting checks (except for this patch) without being too slow.
https://github.com/llvm/llvm-project/pull/66458
More information about the libcxx-commits
mailing list