[libcxx-commits] [PATCH] D151056: [libcxx][libcxxabi][libunwind] Honor CMAKE_SYSROOT in tests

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I believe the latest incarnation of https://github.com/llvm/llvm-project/pull/66265 fixes your issues with the bootstrapping build as well. The reason why I want to go down that route instead of doing this patch is that we should aim to *simplify* how the compiler is invoked and make it closer to what end users will do, instead of adding more and more flags to make it do what we want. This is important because we strive to test-as-we-ship as much as we can, to avoid issues where our test suite doesn't really reflect the reality of how users use the library. If you agree that https://github.com/llvm/llvm-project/pull/66265 solves your problem, let's abandon this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151056/new/

https://reviews.llvm.org/D151056