[libcxx-commits] [PATCH] D159514: [libcxx] <experimental/simd> excluded long double for 32-bits x86 temporarily

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/test/std/experimental/simd/test_utils.h:44
+// TODO: Support long double (12 bytes) for 32-bits x86
+#if defined(__i386__) || defined(__i686__)
 using arithmetic_no_bool_types = types::concatenate_t<types::integer_types, types::type_list<float, double>>;
----------------
It should be quite enough to just check for `__i386__` here - I don't know of any case where `__i686__` is defined but `__i386__` isn't.

FWIW, the previous condition of checking for `#ifdef __MINGW32__` did cover 64 bit mingw too which I presume wasn't intended; the `__MINGW32__` define is set for all mingw targets, even on 64 bit (just like `_WIN32` is defined for all win32 api targets, regardless of whether they're 32 or 64 bit).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159514/new/

https://reviews.llvm.org/D159514