[libcxx-commits] [PATCH] D142902: [libcxx][pmr] Make std::pmr::memory_resource ABI-compatible with GNU libstdc++ and Microsoft STL implementation.

[Ruslan Arutyunyan via Phabricator via libcxx-commits]

rarutyun added a comment.

In D142902#4631440 <https://reviews.llvm.org/D142902#4631440>, @ldionne wrote:

> [Github PR transition cleanup]
>
> I don't know how to say this other than to say that we are reluctant to increase the complexity and the "API surface" (in the general sense of having a contract with users) of the library in order to provide an impression of ABI-compatibility with MSVC. If we wanted to be truly ABI compatible with MSVC in some regards, we would want to have a much more holistic plan than just making sure these function names match and a few data structures happen to have the same layout. That's just too brittle and it creates a haunted graveyard where we'll forever wonder how much leeway we have in making changes to our code because of this presumed ABI compatibility. I also question how much benefit this would provide to users, since I expect the number of people that will try to mix libc++ and the MSVC STL in a way that requires ABI compatibility to be extremely tiny.
>
> Also, generally speaking, mixing stdlibs makes it super easy for users to get into sketchy situations without understanding why. We generally frown upon making changes that suggest it's a good idea. For all these reasons, I believe this patch is not in line with where we want to take the library so I'm going to close it. (Sorry, that requires commandeering and then abandoning which may seem a bit rude, but it's how Phab works)

Hi Louis,

No worries. I am not considering it rude. As I said I see the point of making this patch since you already have some compatibility layer. On the other hand, I can completely understand your arguments. So, to me, it's totally fine to abandon this review if you guys are not interested in those changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142902/new/

https://reviews.llvm.org/D142902