[libcxx-commits] [libcxx] [runtimes] Remove explicit -isysroot from the testing configurations on macOS (PR #66265)

[via libcxx-commits]

================
@@ -2,6 +2,24 @@
 
 @SERIALIZED_LIT_PARAMS@
 
+# Workaround for https://gitlab.kitware.com/cmake/cmake/-/issues/19180.
+#
+# On Apple platforms, CMake resolves the compiler to the final binary using
+# `$(xcrun --find <compiler>`). Unfortunately, running this compiler as-is
+# doesn't work because it doesn't have knowledge of the SDK root. To work
+# around that, we transform the resolved compiler back to the corresponding
+# /usr/bin shim if we can.
+def workaround_cmake_issue_on_Apple(cxx):
----------------
EricWF wrote:

What does this do on non-apple platforms?

It's very important that we test as we ship? How do these changes affect that?

https://github.com/llvm/llvm-project/pull/66265