[libcxx-commits] [libcxx] 9d9a41e - [libc++][hardening] Make the safe mode pipeline run with modules enabled

[Konstantin Varlamov via libcxx-commits]

Author: Konstantin Varlamov
Date: 2023-09-12T23:08:59-07:00
New Revision: 9d9a41e280c24bedc4513edf94ee943d445dfd90

URL: https://github.com/llvm/llvm-project/commit/9d9a41e280c24bedc4513edf94ee943d445dfd90
DIFF: https://github.com/llvm/llvm-project/commit/9d9a41e280c24bedc4513edf94ee943d445dfd90.diff

LOG: [libc++][hardening] Make the safe mode pipeline run with modules enabled

Differential Revision: https://reviews.llvm.org/D159065

Added: 
    

Modified: 
    libcxx/cmake/caches/Generic-safe-mode.cmake
    libcxx/utils/ci/buildkite-pipeline.yml

Removed: 
    


################################################################################
diff  --git a/libcxx/cmake/caches/Generic-safe-mode.cmake b/libcxx/cmake/caches/Generic-safe-mode.cmake
index a792019732b4093..32bef601caaeb88 100644
--- a/libcxx/cmake/caches/Generic-safe-mode.cmake
+++ b/libcxx/cmake/caches/Generic-safe-mode.cmake
@@ -1 +1,2 @@
+set(LIBCXX_ENABLE_STD_MODULES ON CACHE BOOL "") # TODO MODULES Remove when enabled automatically.
 set(LIBCXX_HARDENING_MODE "safe" CACHE STRING "")

diff  --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml
index 870c8f5b39be32d..90bb343f7c7ad03 100644
--- a/libcxx/utils/ci/buildkite-pipeline.yml
+++ b/libcxx/utils/ci/buildkite-pipeline.yml
@@ -505,8 +505,11 @@ steps:
       - "**/test-results.xml"
       - "**/*.abilist"
     env:
-        CC: "clang-${LLVM_HEAD_VERSION}"
-        CXX: "clang++-${LLVM_HEAD_VERSION}"
+        # Note: Modules require an absolute path for `clang-scan-deps` (see
+        # https://github.com/llvm/llvm-project/issues/61006).
+        CC: "/usr/lib/llvm-${LLVM_HEAD_VERSION}/bin/clang"
+        CXX: "/usr/lib/llvm-${LLVM_HEAD_VERSION}/bin/clang++"
+        CMAKE: "/opt/bin/cmake"
         ENABLE_CLANG_TIDY: "On"
     agents:
       queue: "libcxx-builders"