[libcxx-commits] [libcxx] 1d7cec6 - [libc++] Fix broken test in C++03 mode

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 11 18:13:47 PDT 2023


Author: Louis Dionne
Date: 2023-09-11T21:13:35-04:00
New Revision: 1d7cec6adc67d03d55ae75f1f37ffbd844437c74

URL: https://github.com/llvm/llvm-project/commit/1d7cec6adc67d03d55ae75f1f37ffbd844437c74
DIFF: https://github.com/llvm/llvm-project/commit/1d7cec6adc67d03d55ae75f1f37ffbd844437c74.diff

LOG: [libc++] Fix broken test in C++03 mode

Added: 
    

Modified: 
    libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp
    libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter_alloc.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp b/libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp
index 204165c0c4d51e1..3a66bac344c876a 100644
--- a/libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp
+++ b/libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp
@@ -88,13 +88,13 @@ TEST_CONSTEXPR_CXX20 void basic_test_cases() {
       bidirectional_iterator<const int*>(a), bidirectional_iterator<const int*>(an));
   test<std::vector<int, safe_allocator<int> > >(
       random_access_iterator<const int*>(a), random_access_iterator<const int*>(an));
-#endif
 
   // Regression test for https://github.com/llvm/llvm-project/issues/46841
   {
     std::vector<int> v1({}, forward_iterator<const int*>{});
     std::vector<int> v2(forward_iterator<const int*>{}, {});
   }
+#endif
 }
 
 TEST_CONSTEXPR_CXX20 void emplaceable_concept_tests() {

diff  --git a/libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter_alloc.pass.cpp b/libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter_alloc.pass.cpp
index 4414d2f239d059a..42fb5f7c054b6a6 100644
--- a/libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter_alloc.pass.cpp
+++ b/libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter_alloc.pass.cpp
@@ -97,7 +97,6 @@ TEST_CONSTEXPR_CXX20 void basic_tests() {
         random_access_iterator<const int*>(a), random_access_iterator<const int*>(an), alloc);
     test<std::vector<int, safe_allocator<int> > >(a, an, alloc);
   }
-#endif
 
   // Regression test for https://github.com/llvm/llvm-project/issues/46841
   {
@@ -105,6 +104,7 @@ TEST_CONSTEXPR_CXX20 void basic_tests() {
     std::vector<int, min_allocator<int> > v1({}, forward_iterator<const int*>{}, alloc);
     std::vector<int, min_allocator<int> > v2(forward_iterator<const int*>{}, {}, alloc);
   }
+#endif
 }
 
 TEST_CONSTEXPR_CXX20 void emplaceable_concept_tests() {


        


More information about the libcxx-commits mailing list