[libcxx-commits] [libcxx] 8a79af6 - [libc++][AIX] Remove hardcode fail from format test

Jake Egan via libcxx-commits libcxx-commits at lists.llvm.org
Fri Sep 8 10:40:15 PDT 2023


Author: Jake Egan
Date: 2023-09-08T13:40:07-04:00
New Revision: 8a79af676d30a37b82a395cebc866b84157f5236

URL: https://github.com/llvm/llvm-project/commit/8a79af676d30a37b82a395cebc866b84157f5236
DIFF: https://github.com/llvm/llvm-project/commit/8a79af676d30a37b82a395cebc866b84157f5236.diff

LOG: [libc++][AIX] Remove hardcode fail from format test

The test is hardcoded to fail after passing `test_ill_formed_utf16()`. It passes on 32-bit AIX if we remove this.

Reviewed By: Mordante, #libc, ldionne

Differential Revision: https://reviews.llvm.org/D150273

Added: 
    

Modified: 
    libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp b/libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp
index 431e0b6805a1a26..8a83804aee233d2 100644
--- a/libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp
@@ -11,8 +11,8 @@
 // This version runs the test when the platform has Unicode support.
 // UNSUPPORTED: libcpp-has-no-unicode
 
-// TODO FMT Investigate Windows and 32-bit AIX issues.
-// UNSUPPORTED: msvc, target={{.+}}-windows-gnu, target=powerpc-ibm-aix{{.*}}
+// TODO FMT Investigate Windows issues.
+// UNSUPPORTED: msvc, target={{.+}}-windows-gnu
 
 // TODO FMT This test should not require std::to_chars(floating-point)
 // XFAIL: availability-fp_to_chars-missing
@@ -565,7 +565,6 @@ int main(int, char**) {
 #ifndef TEST_HAS_NO_WIDE_CHARACTERS
 #  ifdef _LIBCPP_SHORT_WCHAR
   test_ill_formed_utf16();
-  assert(false);
 #  else  // _LIBCPP_SHORT_WCHAR
   test_ill_formed_utf32();
 #  endif // _LIBCPP_SHORT_WCHAR


        


More information about the libcxx-commits mailing list