[libcxx-commits] [PATCH] D122016: Allow test suite run to be interupted using ctrl-C.

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF abandoned this revision.
EricWF added a comment.

So the difference before and after is that if we ctrl-C during a long running tests, and the test catches it, it effectively swallows it.

This only becomes an issue when we're at the end of the test suite or when only 1 or two tests are running, because otherwise there's a good chance that all the worker threads are running C++ code, and none of them are currently executing pyython which will propagate the error.

I think I would rather actually replace `subprocess.call` with `os.execve` and simply replace the python process with the subprocess. However IDK if that's going to play nice on all platforms we care about.
I'll close this and submit a github PR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122016/new/

https://reviews.llvm.org/D122016