[libcxx-commits] [PATCH] D155141: [libc++][Modules] Group the private detail headers into larger modules

[Ian Anderson via Phabricator via libcxx-commits]

iana abandoned this revision.
iana added a comment.

In D155141#4631516 <https://reviews.llvm.org/D155141#4631516>, @ldionne wrote:

> [Github PR transition cleanup]
>
> I've said it before but I think this is too complicated and we don't have a clear picture of the benefits. I would prefer abandoning this patch, but if you really want to move forward with it, please provide compelling evidence of why this complexity is worth adding.

I still think this results in a better module map; module-per-header solves our requirements but just feels very inelegant. But I think I need to split out some of the variables into the json file like which standards to run and which macros go with which standards. And probably convert that into a Python file akin to header_info.py. I'm also maybe overestimating how often the module map needs to change, and maybe it could be a regular generated file instead. I'll abandon this for now, and if we end up needing it after llvm 17 ships, or I get a bit of time to work on it and I'm still bummed about all the work I put in on this, I'll try it for review on GitHub.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155141/new/

https://reviews.llvm.org/D155141