[libcxx-commits] [PATCH] D159454: [libc++][hardening][NFC] Fix the 17 release notes to remove mentions of hardening
Konstantin Varlamov via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Sep 7 20:55:33 PDT 2023
var-const added inline comments.
================
Comment at: libcxx/docs/ReleaseNotes/17.rst:82
- P2286R8 - Formatting Ranges
- P2508R1 - Exposing std::basic-format-string
----------------
ldionne wrote:
> var-const wrote:
> > ldionne wrote:
> > > We also discussed updating some TODO(LLVM18) blocks, I think those are missing from the patch.
> > Hmm, do you have something specific in mind? I couldn't find any of those TODOs in the release notes or documentation. There are a couple in `__config` and `CMakeLists.txt`, but I thought to keep this patch limited to just the docs (but of course it doesn't have to be if you'd prefer to do everything in one go).
> I think it makes sense for this patch to fix all the discrepancies introduced by the last-minute change we made on `release/17.x` (in one go). I could find this with grep: `# TODO(LLVM 18): Remove this after branching for LLVM 17, this is a simple [...]`. There's probably others!
I found 3 such TODOs and bumped the LLVM release version. Please let me know if that's not what you had in mind!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159454/new/
https://reviews.llvm.org/D159454
More information about the libcxx-commits
mailing list