[libcxx-commits] [PATCH] D150766: [libcxx] [ci] Add a test configuration with an incomplete sysroot

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 7 12:54:29 PDT 2023


mstorsjo added a comment.

So, FWIW, my view is that this patch would add valuable test coverage as-is.

It should be theoretically possible to set up something similar on linux as well, but it's not necessarily as straightforward (as it'd require setting up an environment that hard defaults to libunwind etc, to get the same test coverage as this gets). If it's a hard requirement for adding this kind of test scenario to have it running on Linux and not Windows, then I'd defer it until some time later when I have time to try to set it up. But as is, this patch gives lots of extra valuable test coverage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150766/new/

https://reviews.llvm.org/D150766



More information about the libcxx-commits mailing list