[libcxx-commits] [PATCH] D158215: [libc++][NFC] Remove __has_keyword

[Hubert Tong via Phabricator via libcxx-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: libcxx/include/__config:1157
 
-#  if __has_feature(cxx_atomic) || __has_extension(c_atomic) || __has_keyword(_Atomic)
+#  if __has_feature(cxx_atomic) || __has_extension(c_atomic)
 #    define _LIBCPP_HAS_C_ATOMIC_IMP
----------------
philnik wrote:
> Mordante wrote:
> > Why is this NFC?
> Because this is always false for GCC and always true for Clang.
This is not NFC: `-std=gnu++98 -pedantic-errors` has this evaluate to false for Clang.

https://godbolt.org/z/xsfvhEfz9


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158215/new/

https://reviews.llvm.org/D158215