[libcxx-commits] [PATCH] D154282: [libc++][chrono] Adds tzdb_list implementation.

Wed Sep 6 14:06:09 PDT 2023

abrachet added a comment.

We are seeing build failures after this patch. See https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-mac-xarm64/b8770674124156502625/overview.

  FAILED: libcxx/src/CMakeFiles/cxx_experimental.dir/tzdb_list.cpp.o 
  /opt/s/w/ir/x/w/llvm_build/./bin/clang++ --target=armv7-unknown-linux-gnueabihf --sysroot=/opt/s/w/ir/x/w/cipd/linux -DLIBCXX_BUILDING_LIBCXXABI -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_ENABLE_HARDENED_MODE -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_LINK_PTHREAD_LIB -D_LIBCPP_LINK_RT_LIB -D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/opt/s/w/ir/x/w/llvm_build/tools/clang/stage2-bins/include/c++/v1 -I/opt/s/w/ir/x/w/llvm_build/tools/clang/stage2-bins/include/armv7-unknown-linux-gnueabihf/c++/v1 -I/opt/s/w/ir/x/w/llvm-llvm-project/libcxxabi/include -resource-dir=/opt/s/w/ir/x/w/llvm_build/tools/clang/stage2-bins/./lib/clang/18 --target=armv7-unknown-linux-gnueabihf -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -ffile-prefix-map=/opt/s/w/ir/x/w/llvm_build/tools/clang/stage2-bins/runtimes/runtimes-armv7-unknown-linux-gnueabihf-bins=../llvm_build/tools/clang/stage2-bins/runtimes/runtimes-armv7-unknown-linux-gnueabihf-bins -ffile-prefix-map=/opt/s/w/ir/x/w/llvm-llvm-project/= -no-canonical-prefixes -O2 -g -DNDEBUG -std=c++20 -UNDEBUG -faligned-allocation -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -Wall -Wextra -Wnewline-eof -Wshadow -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wundef -Wunused-template -Wformat-nonliteral -Wno-user-defined-literals -Wno-covered-switch-default -Wno-suggest-override -Wno-error -D_LIBCPP_ENABLE_EXPERIMENTAL -MD -MT libcxx/src/CMakeFiles/cxx_experimental.dir/tzdb_list.cpp.o -MF libcxx/src/CMakeFiles/cxx_experimental.dir/tzdb_list.cpp.o.d -o libcxx/src/CMakeFiles/cxx_experimental.dir/tzdb_list.cpp.o -c /opt/s/w/ir/x/w/llvm-llvm-project/libcxx/src/tzdb_list.cpp
  /opt/s/w/ir/x/w/llvm-llvm-project/libcxx/src/tzdb_list.cpp:29:7: error: use of undeclared identifier 'tzdb_list'
     29 | class tzdb_list::__impl {
        |       ^
  /opt/s/w/ir/x/w/llvm-llvm-project/libcxx/src/tzdb_list.cpp:81:27: error: use of undeclared identifier 'tzdb_list'
     81 | _LIBCPP_EXPORTED_FROM_ABI tzdb_list::tzdb_list(tzdb&& __tzdb) : __impl_{new __impl(std::move(__tzdb))} {}
        |                           ^
  ...

Would you mind taking a look?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154282/new/

https://reviews.llvm.org/D154282