[libcxx-commits] [PATCH] D158936: [libc++][C++20 modules] Tests no experimental library build.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Sep 6 10:27:47 PDT 2023


Mordante added a comment.

In D158936#4639045 <https://reviews.llvm.org/D158936#4639045>, @h-vetinari wrote:

>> Depends on D158662 <https://reviews.llvm.org/D158662>
>
> I think you probably meant https://reviews.llvm.org/D158661, not https://reviews.llvm.org/D158662

Thanks that indeed is a typo.

In D158936#4639729 <https://reviews.llvm.org/D158936#4639729>, @ldionne wrote:

> LGTM but make sure your commit message references the right patch!

I just removed the dependency; all dependencies have landed. I tested the patch yesterday in Buildkite since to original failed. I expected it was due to the large stack, but it probably was due to the wrong dependency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158936/new/

https://reviews.llvm.org/D158936



More information about the libcxx-commits mailing list