[libcxx-commits] [PATCH] D121154: [libc++] Add a test for std::ssize's SFINAE

[Louis Dionne via Phabricator via libcxx-commits]

ldionne updated this revision to Diff 556025.
ldionne added a comment.

Don't hardcode -m32, instead only run the test on 32 bit platforms.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121154/new/

https://reviews.llvm.org/D121154

Files:
  libcxx/test/std/iterators/iterator.container/ssize.LWG3207.compile.pass.cpp


Index: libcxx/test/std/iterators/iterator.container/ssize.LWG3207.compile.pass.cpp
===================================================================
--- /dev/null
+++ libcxx/test/std/iterators/iterator.container/ssize.LWG3207.compile.pass.cpp
@@ -0,0 +1,37 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+
+// <iterator>
+
+// template <class T, ptrdiff_t N>
+//   constexpr ptrdiff_t ssize(const T (&array)[N]) noexcept;
+//
+// This test checks that the library implements LWG3207 as not-a-defect.
+// `clang -m32` is an example of a configuration where using ptrdiff_t
+// instead of size_t in std::ssize has an observable SFINAE effect.
+//
+// REQUIRES: 32-bit-pointer
+
+#include <iterator>
+#include <climits>
+#include <cstddef>
+
+// Test the test:
+static_assert(sizeof(std::ptrdiff_t) == 4, "Run only on these platforms");
+static_assert(sizeof(std::size_t) == 4, "Run only on these platforms");
+static_assert(std::size_t(PTRDIFF_MAX) + 1 > std::size_t(PTRDIFF_MAX), "This should always be true");
+extern char forming_this_type_must_be_valid_on_this_platform[std::size_t(PTRDIFF_MAX) + 1];
+
+// The actual test:
+template <class T>
+concept HasSsize = requires(T&& t) { std::ssize(t); };
+
+static_assert(HasSsize<char[std::size_t(PTRDIFF_MAX)]>);
+static_assert(!HasSsize<char[std::size_t(PTRDIFF_MAX) + 1]>);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121154.556025.patch
Type: text/x-patch
Size: 1705 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230906/88b041a0/attachment.bin>